risdenk commented on a change in pull request #242: KNOX-2190 - Processing
advanced service discovery configuration on topology level
URL: https://github.com/apache/knox/pull/242#discussion_r369648281
##########
File path:
gateway-cm-integration/src/main/java/org/apache/knox/gateway/cm/descriptor/ClouderaManagerDescriptorMonitor.java
##########
@@ -61,25 +63,25 @@ public ClouderaManagerDescriptorMonitor(GatewayConfig
gatewayConfig, ClouderaMan
public void setupMonitor() {
if (monitoringInterval > 0) {
- executorService.scheduleAtFixedRate(() ->
monitorClouderaManagerDescriptors(false), 0, monitoringInterval,
TimeUnit.MILLISECONDS);
+ executorService.scheduleAtFixedRate(() ->
monitorClouderaManagerDescriptors(null), 0, monitoringInterval,
TimeUnit.MILLISECONDS);
Review comment:
Passing in `null` explicitly seems wrong...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
