[
https://issues.apache.org/jira/browse/KNOX-2153?focusedWorklogId=375949&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375949
]
ASF GitHub Bot logged work on KNOX-2153:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jan/20 22:33
Start Date: 22/Jan/20 22:33
Worklog Time Spent: 10m
Work Description: risdenk commented on pull request #239: KNOX-2153 - CM
discovery - Monitor Cloudera Manager
URL: https://github.com/apache/knox/pull/239#discussion_r369837792
##########
File path:
gateway-discovery-cm/src/main/java/org/apache/knox/gateway/topology/discovery/cm/monitor/ServiceConfigurationRecordObjectMapper.java
##########
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package org.apache.knox.gateway.topology.discovery.cm.monitor;
+
+import com.fasterxml.jackson.core.JsonGenerator;
+import com.fasterxml.jackson.core.JsonParser;
+import com.fasterxml.jackson.core.Version;
+import com.fasterxml.jackson.databind.DeserializationContext;
+import com.fasterxml.jackson.databind.JsonNode;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.SerializerProvider;
+import com.fasterxml.jackson.databind.deser.std.StdDeserializer;
+import com.fasterxml.jackson.databind.module.SimpleModule;
+import com.fasterxml.jackson.databind.ser.std.StdSerializer;
+
+import java.io.IOException;
+import java.util.Iterator;
+
+/**
+ * Custom ObjectMapper implementation for serializing/deserializing
ServiceConfigurationRecord objects.
+ */
+class ServiceConfigurationRecordObjectMapper extends ObjectMapper {
Review comment:
So this could be ignorance regarding Jackson, but I thought we could just
annotate the class instead of having to write custom serialize/deserialize
stuff. We use Jackson elsewhere and no where else do we `extends ObjectMapper`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 375949)
Time Spent: 5h 50m (was: 5h 40m)
> CM discovery - Monitor Cloudera Manager
> ---------------------------------------
>
> Key: KNOX-2153
> URL: https://issues.apache.org/jira/browse/KNOX-2153
> Project: Apache Knox
> Issue Type: Sub-task
> Components: cm-discovery
> Affects Versions: 1.4.0
> Reporter: Sandor Molnar
> Assignee: Philip Zampino
> Priority: Major
> Time Spent: 5h 50m
> Remaining Estimate: 0h
>
> Knox needs to have monitoring capabilities implemented for Cloudera Manager
> service-discovery the same way as supported for Ambari (see KNOX-1013).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
