risdenk opened a new pull request #243: KNOX-2200 - DefaultKeystoreService can lose entires under concurrent access URL: https://github.com/apache/knox/pull/243 ## What changes were proposed in this pull request? Add synchronization to `addCredentialForCluster` and `removeCredentialForCluster` to prevent read then write synchronization issues. Added a test that failed without this change for each method and then confirmed passed with fix. ## How was this patch tested? * Checked new unit test fails without change * Checked new unit test doesn't fail with change * `mvn -T.75C verify -Ppackage,release -Dshellcheck`
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
