risdenk commented on a change in pull request #250: KNOX-2209 - Improve logging 
for Knox token handling
URL: https://github.com/apache/knox/pull/250#discussion_r373615072
 
 

 ##########
 File path: 
gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java
 ##########
 @@ -384,4 +391,9 @@ private long getExpiry() {
     }
     return expiry;
   }
+
+  private String getTopologyName() {
+    return (String) 
context.getAttribute("org.apache.knox.gateway.gateway.cluster");
 
 Review comment:
   nit: Would be good to make this a constant. I ran into this looking into 
something else. It was NOT clear that this attribute was the topology name.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to