risdenk commented on a change in pull request #260: KNOX-2228 - JWTFilter 
should handle unknown token exception from toke…
URL: https://github.com/apache/knox/pull/260#discussion_r377179358
 
 

 ##########
 File path: 
gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/JWTMessages.java
 ##########
 @@ -41,6 +41,9 @@
   @Message( level = MessageLevel.INFO, text = "Unable to verify token: {0}" )
   void unableToVerifyToken(@StackTrace( level = MessageLevel.ERROR) Exception 
e);
 
+  @Message( level = MessageLevel.ERROR, text = "Unable to verify token 
expiration: {0}" )
 
 Review comment:
   INFO or WARN should be good I think. I just saw the message above about 
unable to verify being INFO and was like hmmm that seems worse than not being 
able to verify the expiration.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to