[
https://issues.apache.org/jira/browse/KNOX-2214?focusedWorklogId=385177&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-385177
]
ASF GitHub Bot logged work on KNOX-2214:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Feb/20 14:18
Start Date: 11/Feb/20 14:18
Worklog Time Spent: 10m
Work Description: pzampino commented on pull request #257: KNOX-2214 -
Periodic job to evict expired tokens
URL: https://github.com/apache/knox/pull/257#discussion_r377660374
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/services/token/impl/DefaultTokenStateService.java
##########
@@ -264,4 +280,29 @@ protected String getTokenDisplayText(final String token) {
return String.format(Locale.ROOT, "%s...%s", token.substring(0, 10),
token.substring(token.length() - 3));
}
+ /**
+ * Method that deletes expired tokens based on the token timestamp.
+ */
+ protected void evictExpiredTokens() {
+ try {
+ for (final String token : getTokens()) {
+ if (isExpired(token)) {
+ log.evictToken(getTokenDisplayText(token));
+ removeToken(token);
+ }
+ }
+ } catch(final Exception e) {
Review comment:
Would it not be better to catch the error for each eviction attempt, and
continue trying the others when one fails, rather than failing the whole
attempt because of a single error?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 385177)
Time Spent: 3h 10m (was: 3h)
> Reaping of expired Knox tokens
> ------------------------------
>
> Key: KNOX-2214
> URL: https://issues.apache.org/jira/browse/KNOX-2214
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Affects Versions: 1.4.0
> Reporter: Philip Zampino
> Assignee: Sandeep More
> Priority: Major
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> When the TokenStateService is employed, if Knox-issued tokens aren't
> explicitly cancelled, then they remain in the persistent store forever. The
> TokenStateService should maintain a thread that removes expired tokens.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)