[
https://issues.apache.org/jira/browse/KNOX-2226?focusedWorklogId=386209&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386209
]
ASF GitHub Bot logged work on KNOX-2226:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Feb/20 20:34
Start Date: 12/Feb/20 20:34
Worklog Time Spent: 10m
Work Description: risdenk commented on pull request #263: [WIP] KNOX-2226
- Add home page to Knox
URL: https://github.com/apache/knox/pull/263#discussion_r378492211
##########
File path:
knox-homepage-backend/src/main/java/org/apache/knox/homepage/TopologyInformationWrapperMarshaller.java
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.knox.homepage;
+
+import java.io.IOException;
+import java.io.OutputStream;
+import java.lang.annotation.Annotation;
+import java.lang.reflect.Type;
+import java.util.HashMap;
+import java.util.Map;
+
+import javax.ws.rs.Produces;
+import javax.ws.rs.WebApplicationException;
+import javax.ws.rs.core.MediaType;
+import javax.ws.rs.core.MultivaluedMap;
+import javax.ws.rs.ext.MessageBodyWriter;
+import javax.ws.rs.ext.Provider;
+import javax.xml.bind.JAXBException;
+import javax.xml.bind.Marshaller;
+
+import org.eclipse.persistence.jaxb.JAXBContextFactory;
+import org.eclipse.persistence.jaxb.JAXBContextProperties;
+
+@Provider
+@Produces({ MediaType.APPLICATION_XML, MediaType.APPLICATION_JSON })
+public class TopologyInformationWrapperMarshaller implements
MessageBodyWriter<TopologyInformationWrapper> {
+ private static Marshaller xmlMarshaller;
+ private static Marshaller jsonMarshaller;
+
+ @Override
+ public boolean isWriteable(Class<?> type, Type genericType, Annotation[]
annotations, MediaType mediaType) {
+ return TopologyInformationWrapper.class == type;
+ }
+
+ @Override
+ public long getSize(TopologyInformationWrapper t, Class<?> type, Type
genericType, Annotation[] annotations, MediaType mediaType) {
+ return -1;
+ }
+
+ @Override
+ public void writeTo(TopologyInformationWrapper instance, Class<?> type, Type
genericType, Annotation[] annotations, MediaType mediaType,
+ MultivaluedMap<String, Object> httpHeaders, OutputStream entityStream)
throws IOException, WebApplicationException {
+ try {
+ getMarshaller(mediaType).marshal(instance, entityStream);
+ } catch (JAXBException e) {
+ throw new IOException(e);
+ }
+ }
+
+ private Marshaller getMarshaller(MediaType mediaType) throws JAXBException {
+ return
MediaType.APPLICATION_JSON_TYPE.getSubtype().equals(mediaType.getSubtype()) ?
getJsonMarshaller() : getXmlMarshaller();
+ }
+
+ private synchronized Marshaller getXmlMarshaller() throws JAXBException {
Review comment:
Need to make sure this is a safe marshaller and we aren't open to XML
issues. I thought we had a class to handle a lot of this complexity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 386209)
Time Spent: 50m (was: 40m)
> Add home page to Knox
> ---------------------
>
> Key: KNOX-2226
> URL: https://issues.apache.org/jira/browse/KNOX-2226
> Project: Apache Knox
> Issue Type: New Feature
> Components: AdminUI
> Affects Versions: 1.3.0
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Major
> Labels: UI
> Fix For: 1.4.0
>
> Attachments: OnePager-Apache_Knox_Home_Page.pdf
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The lack of a home or landing page for Knox leaves users without a well-known
> place to discover the URLs for the various UIs and APIs that are being
> exposed for access by the gateway.
> This results in the need for QuickLinks in management applications like
> Ambari and Cloudera Manager to be rewritten to express the proxied URLs. This
> also results in the need for users to have to continue to go to these
> management applications for end-user URLs which is often not even appropriate.
> This proposal is for adding a Home page to Apache Knox which will present the
> various URLs in ways that are intuitive for being able to consume the proxied
> resources.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
