risdenk commented on a change in pull request #263: [WIP] KNOX-2226 - Add home 
page to Knox
URL: https://github.com/apache/knox/pull/263#discussion_r378492765
 
 

 ##########
 File path: gateway-release/pom.xml
 ##########
 @@ -144,6 +144,14 @@
                                             
<outputDirectory>${project.build.directory}</outputDirectory>
                                             
<includes>applications/**/*</includes>
                                         </artifactItem>
+                                        <artifactItem>
 
 Review comment:
   Need to see what this looks like in the final tar.gz to make sure this is 
valid packaging since `gateway-release` basically builds the final apache 
builds.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to