[
https://issues.apache.org/jira/browse/KNOX-2212?focusedWorklogId=394263&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-394263
]
ASF GitHub Bot logged work on KNOX-2212:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Feb/20 15:58
Start Date: 27/Feb/20 15:58
Worklog Time Spent: 10m
Work Description: pzampino commented on pull request #274: KNOX-2212 -
Token permissiveness
URL: https://github.com/apache/knox/pull/274#discussion_r385195059
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/config/impl/GatewayConfigImpl.java
##########
@@ -249,8 +249,10 @@
private static final String KNOX_TOKEN_EVICTION_INTERVAL =
GATEWAY_CONFIG_FILE_PREFIX + ".knox.token.eviction.interval";
private static final String KNOX_TOKEN_EVICTION_GRACE_PERIOD =
GATEWAY_CONFIG_FILE_PREFIX + ".knox.token.eviction.grace.period";
+ private static final String KNOX_TOKEN_PERMISSIVE_FAILURE_ENABLED =
GATEWAY_CONFIG_FILE_PREFIX + ".knox.token.permissive.failure.enabled";
private static final long KNOX_TOKEN_EVICTION_INTERVAL_DEFAULT =
TimeUnit.MINUTES.toSeconds(5);
private static final long KNOX_TOKEN_EVICTION_GRACE_PERIOD_DEFAULT =
TimeUnit.MINUTES.toSeconds(5);
+ private static final boolean KNOX_TOKEN_PERMISSIVE_FAILURE_ENABLED_DEFAULT =
false;
Review comment:
Again, I think we should treat this in terms of validation rather than
failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 394263)
Time Spent: 1h 20m (was: 1h 10m)
> TokenStateService should fail permissively
> ------------------------------------------
>
> Key: KNOX-2212
> URL: https://issues.apache.org/jira/browse/KNOX-2212
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Affects Versions: 1.4.0
> Reporter: Philip Zampino
> Assignee: Sandeep More
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> While unlikely, it's possible that the TokenStateService may be presented
> with a token, for which it has no state, but which can be verified as a valid
> (origin, expiration, etc...) token. In these cases, rather than rejecting the
> token for lack of server-managed state, the token's state should be recorded,
> and the associated operation permitted.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
