smolnar82 opened a new pull request #287: KNOX-2286 Cleaner log messages about monitoring topologies/providers/descriptors URL: https://github.com/apache/knox/pull/287 ## What changes were proposed in this pull request? Clearly indicating in the logs when - a monitor (topologies/providers/descriptors) is configured - a monitor (topologies/providers/descriptors) is started As part of this job, I refactored out the `SharedProviderConfigMonitor` and `DescriptorsMonitor` classes from `DefaultTopologyService` into a new package (`org.apache.knox.gateway.services.topology.monitor`). ## How was this patch tested? Redeployed Knox with my changes and touched files in `conf/shared-providers`, `conf/descriptors` and `conf/topologies` directories: monitoring worked as expected. Relevant logs: ``` 2020-03-11 17:27:22,838 INFO knox.gateway (DefaultTopologyService.java:init(643)) - Configured monitoring topologies in directory: /Users/smolnar/test/knoxGateway/conf/topologies 2020-03-11 17:27:22,839 INFO knox.gateway (DefaultTopologyService.java:init(648)) - Configured monitoring simple descriptors in directory: /Users/smolnar/test/knoxGateway/conf/descriptors 2020-03-11 17:27:23,061 INFO knox.gateway (DefaultTopologyService.java:init(653)) - Configured monitoring shared provider configurations in directory: /Users/smolnar/test/knoxGateway/conf/shared-providers ... 2020-03-11 17:27:31,951 INFO knox.gateway (DefaultTopologyService.java:startMonitor(548)) - Started monitoring simple descriptors 2020-03-11 17:27:31,951 INFO knox.gateway (DefaultTopologyService.java:startMonitor(548)) - Started monitoring shared provider configurations 2020-03-11 17:27:31,952 INFO knox.gateway (DefaultTopologyService.java:startMonitor(548)) - Started monitoring topologies ... ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
