pzampino commented on a change in pull request #297: KNOX-2301 and KNOX-2302
URL: https://github.com/apache/knox/pull/297#discussion_r395995034
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/services/topology/impl/DefaultTopologyService.java
##########
@@ -153,17 +146,18 @@ private Topology loadTopology(File file) throws
IOException, SAXException, Inter
return topology;
}
+ @Override
+ public Topology parse(final InputStream content) throws IOException,
SAXException {
+ return TopologyUtils.parse(content);
+ }
+
private Topology loadTopologyAttempt(File file) throws IOException,
SAXException {
- Topology topology;
- Digester digester = digesterLoader.newDigester();
- TopologyBuilder topologyBuilder =
digester.parse(FileUtils.openInputStream(file));
- if (null == topologyBuilder) {
- return null;
- }
- topology = topologyBuilder.build();
- topology.setUri(file.toURI());
- topology.setName(FilenameUtils.removeExtension(file.getName()));
- topology.setTimestamp(file.lastModified());
+ Topology topology = parse(FileUtils.openInputStream(file));
Review comment:
The reason for the TopologyService method taking an InputStream (rather than
a File) is that there is not a File available in every case. In one case, it is
being used to parse a generated String. There could be two signatures, but I
think the InputStream signature supports the two existing cases well enough.
The streams must be closed though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
