[
https://issues.apache.org/jira/browse/KNOX-2301?focusedWorklogId=407429&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-407429
]
ASF GitHub Bot logged work on KNOX-2301:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Mar/20 14:14
Start Date: 21/Mar/20 14:14
Worklog Time Spent: 10m
Work Description: pzampino commented on pull request #297: KNOX-2301 and
KNOX-2302
URL: https://github.com/apache/knox/pull/297#discussion_r395996016
##########
File path:
gateway-topology-simple/src/main/java/org/apache/knox/gateway/topology/simple/TopologyComparisonUtil.java
##########
@@ -0,0 +1,192 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package org.apache.knox.gateway.topology.simple;
+
+import org.apache.knox.gateway.topology.Application;
+import org.apache.knox.gateway.topology.Provider;
+import org.apache.knox.gateway.topology.Service;
+import org.apache.knox.gateway.topology.Topology;
+
+import java.util.Collection;
+import java.util.List;
+import java.util.Map;
+
+/**
+ * Utility for comparing Topology objects for equivalence.
+ */
+class TopologyComparisonUtil {
Review comment:
This thought had crossed my mind as I was implementing it; I think the fact
that this requirement doesn't care about the URI, default service path or
timestamp is what made me opt for this. I think a complete equals()
implementation would include at least the URI, but if others disagree, I could
be persuaded to move this logic into the Topology equals() method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 407429)
Time Spent: 1h 20m (was: 1h 10m)
> Trigger discovery for descriptors at gateway start time
> -------------------------------------------------------
>
> Key: KNOX-2301
> URL: https://issues.apache.org/jira/browse/KNOX-2301
> Project: Apache Knox
> Issue Type: Improvement
> Components: Server
> Affects Versions: 1.4.0
> Reporter: Philip Zampino
> Assignee: Philip Zampino
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Discovery and topology generation is triggered only by changes to provider
> configuration or descriptor files on disk. Knox should also perform discovery
> for all existing descriptors (that include discovery config) when the gateway
> is started.
> This will help ensure that the generated topologies are accurate reflections
> of the proxied services' configurations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
