lmccay opened a new pull request #301: KNOX-2307 - CSVKnoxShellTableBuilder 
must support quoted strings and …
URL: https://github.com/apache/knox/pull/301
 
 
   …embedded commas
   
   Change-Id: I82e096d204accc0ba6a334b18d6287eb67adf74c
   
   (It is very **important** that you created an Apache Knox JIRA for this 
change and that the PR title/commit message includes the Apache Knox JIRA ID!)
   
   ## What changes were proposed in this pull request?
   Embedded commas within a quoted string/col in CSV files result in separate 
cols currently. This patch allows for them to be ignored during the split() 
call via regex for identifying such patterns.
   
   It will result in the value - either header or cell value - as retaining the 
quotes currently. If this is not desired we can revisit and make configurable 
or just removed.
   
   
   ## How was this patch tested?
   
   New unit test added and existing unit tests ran.
   Manually tested against datasets with and without such quoted strings and 
embedded commas.
   
   Please review [Knox Contributing 
Process](https://cwiki.apache.org/confluence/display/KNOX/Contribution+Process#ContributionProcess-GithubWorkflow)
 before opening a pull request.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to