pzampino commented on a change in pull request #304: KNOX-2315 - Fix zookeeper 
Kerberos Auth
URL: https://github.com/apache/knox/pull/304#discussion_r404973322
 
 

 ##########
 File path: 
gateway-service-remoteconfig/src/main/java/org/apache/knox/gateway/service/config/remote/zk/CuratorClientService.java
 ##########
 @@ -124,7 +125,14 @@ private RemoteConfigurationRegistryClient 
createClient(RemoteConfigurationRegist
         ACLProvider aclProvider;
         if (config.isSecureRegistry()) {
             configureSasl(config);
-            aclProvider = new SASLOwnerACLProvider();
+            if (!StringUtils.isBlank(config.getAuthType()) && config
 
 Review comment:
   I was thinking you can define a static method in a class that is accessible 
to all that need to reference it, which takes a String (the 
authenticationType() result).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to