[
https://issues.apache.org/jira/browse/KNOX-2340?focusedWorklogId=420633&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-420633
]
ASF GitHub Bot logged work on KNOX-2340:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Apr/20 01:37
Start Date: 11/Apr/20 01:37
Worklog Time Spent: 10m
Work Description: risdenk commented on pull request #312: KNOX-2340 - Fix
DefaultTokenStateServiceTest timeouts
URL: https://github.com/apache/knox/pull/312
## What changes were proposed in this pull request?
Fix DefaultTokenStateServiceTest timeouts to be more reasonable. I used
TimeUnit every where to ensure we are doing things with the correct unit of
time. Previously there were issues where milliseconds and seconds were being
mixed. This caused race conditions in AliasBasedTokenStateServiceTest which
extends DefaultTokenStateServiceTest.
## How was this patch tested?
* Ran `AliasBasedTokenStateServiceTest` and `DefaultTokenStateServiceTest`
repeatedly in IDE
* `mvn -T.5C package -DskipTests -Ppackage,release -Dshellcheck`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 420633)
Remaining Estimate: 0h
Time Spent: 10m
> AliasBasedTokenStateServiceTest failure
> ---------------------------------------
>
> Key: KNOX-2340
> URL: https://issues.apache.org/jira/browse/KNOX-2340
> Project: Apache Knox
> Issue Type: Bug
> Components: Tests
> Reporter: Kevin Risden
> Assignee: Kevin Risden
> Priority: Major
> Fix For: 1.4.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This looks to be a race condition somehow since I haven't seen this locally.
> {code:java}
> 2020-04-10T22:03:10.7648621Z [ERROR]
> AliasBasedTokenStateServiceTest>DefaultTokenStateServiceTest.testTokenEviction:214
> unexpected exception type thrown;
> expected:<org.apache.knox.gateway.services.security.token.UnknownTokenException>
> but was:<java.lang.IllegalArgumentException>
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
