moresandeep commented on a change in pull request #323:
URL: https://github.com/apache/knox/pull/323#discussion_r412974333
##########
File path:
gateway-service-definitions/src/main/resources/services/atlas/2.0.0/rewrite.xml
##########
@@ -28,48 +28,15 @@
<rewrite template="{$serviceUrl[ATLAS]}/{**}?{**}"/>
</rule>
- <rule dir="OUT" name="ATLAS/atlas/outbound/links" pattern="css/{**}">
Review comment:
How are these resources handled now? does the Atlas UI take care of
this? if so wouldn't it be better to create a new version of Knox rules so
someone using the un-patched or older Atlas UI has some way to get around this
breaking change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]