[ 
https://issues.apache.org/jira/browse/KNOX-2390?focusedWorklogId=448003&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-448003
 ]

ASF GitHub Bot logged work on KNOX-2390:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Jun/20 19:53
            Start Date: 18/Jun/20 19:53
    Worklog Time Spent: 10m 
      Work Description: pzampino commented on a change in pull request #348:
URL: https://github.com/apache/knox/pull/348#discussion_r442466141



##########
File path: 
gateway-provider-security-pac4j/src/main/java/org/apache/knox/gateway/pac4j/config/Pac4jClientConfigurationDecorator.java
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.knox.gateway.pac4j.config;
+
+import java.util.Arrays;
+import java.util.List;
+import java.util.Map;
+
+import org.pac4j.core.client.Client;
+
+public class Pac4jClientConfigurationDecorator implements 
ClientConfigurationDecorator {
+
+  private static final List<ClientConfigurationDecorator> DEFAULT_DECORATORS = 
Arrays.asList(new SAML2ClientConfigurationDecorator(), new 
AzureADClientConfigurationDecorator());
+  private final List<ClientConfigurationDecorator> decorators;
+
+  public Pac4jClientConfigurationDecorator() {
+    this(DEFAULT_DECORATORS);
+  }
+
+  // package protected so that it's visible in unit tests

Review comment:
       My personal preference is to assign the appropriate visibility based on 
the functionality, and use reflection if necessary from unit tests.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 448003)
    Time Spent: 40m  (was: 0.5h)

> Configure SAML using provider parameters
> ----------------------------------------
>
>                 Key: KNOX-2390
>                 URL: https://issues.apache.org/jira/browse/KNOX-2390
>             Project: Apache Knox
>          Issue Type: Task
>          Components: Server
>    Affects Versions: 1.4.0
>            Reporter: Sandor Molnar
>            Assignee: Sandor Molnar
>            Priority: Major
>             Fix For: 1.5.0
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Currently, there is a bunch of SAML parameters which the Pac4j federation 
> provider knows about and can be used to update SAML 2 configuration:
>  * saml.keystorePassword
>  * saml.privateKeyPassword
>  * saml.keystorePath
>  * saml.keystoreAlias
>  * saml.identityProviderMetadataPath
>  * saml.maximumAuthenticationLifetime
>  * saml.serviceProviderEntityId
>  * saml.serviceProviderMetadataPath
>  * saml.destinationBindingType
> However, there are other SAML 2 configurations that also should be 
> configurable via provider parameters. For instance: the default value of 
> {{useNameQualifier}} changed from {{'false'}} to {{'true'}} in pac4j 
> {{v3.7.0}} (and changed back to {{'false'}} in {{v3.8.2}}) which may cause an 
> issue with ADFS integration.
> The purpose of this Jira is to identify a list of SAML 2 configuration that 
> should be configurable and make it happen via the Pac4j federation provider 
> parameters.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to