moresandeep commented on a change in pull request #349:
URL: https://github.com/apache/knox/pull/349#discussion_r442750062
##########
File path:
gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/SSOCookieFederationFilter.java
##########
@@ -92,6 +100,18 @@ public void init( FilterConfig filterConfig ) throws
ServletException {
publicKey = CertificateUtils.parseRSAPublicKey(verificationPEM);
}
+ /* get unauthenticated paths list */
+ String unAuthPathString =
filterConfig.getInitParameter(SSO_UNAUTHENTICATED_PATHS_PARAM);
+ /* if no list specified use default value */
+ if (StringUtils.isBlank(unAuthPathString)) {
+ unAuthPathString = DEFAULT_SSO_UNAUTHENTICATED_PATHS_PARAM;
+ }
+
+ final StringTokenizer st = new StringTokenizer(unAuthPathString, ";");
Review comment:
Yeah that is a good idea, i was conflicted whether to support ","
decided not to include to be in line with other config props.
I will update it to support ",".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]