[ 
https://issues.apache.org/jira/browse/KNOX-2393?focusedWorklogId=448469&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-448469
 ]

ASF GitHub Bot logged work on KNOX-2393:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Jun/20 13:22
            Start Date: 19/Jun/20 13:22
    Worklog Time Spent: 10m 
      Work Description: moresandeep commented on a change in pull request #349:
URL: https://github.com/apache/knox/pull/349#discussion_r442836972



##########
File path: 
gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/SSOCookieFederationFilter.java
##########
@@ -121,13 +141,25 @@ public void doFilter(ServletRequest request, 
ServletResponse response, FilterCha
 
     List<Cookie> ssoCookies = CookieUtils.getCookiesForName(req, cookieName);
     if (ssoCookies.isEmpty()) {
+      /* check for unauthenticated paths to bypass */
+      for (final String path : unAuthenticatedPaths) {
+        if (req.getRequestURI().contains(path)) {
+          /* This path is configured as an unauthenticated path let the 
request through */
+          final Subject sub = new Subject();
+          sub.getPrincipals().add(new PrimaryPrincipal("anonymous"));
+          LOGGER.unAuthenticatePathBypass(path, req.getRequestURI());
+          continueWithEstablishedSecurityContext(sub, req, res, chain);
+        }
+      }
+
       if (req.getMethod().equals("OPTIONS")) {

Review comment:
       Good catch!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 448469)
    Time Spent: 1h 20m  (was: 1h 10m)

> Add a configurable list of paths that SSOCookieProvider can ignore
> ------------------------------------------------------------------
>
>                 Key: KNOX-2393
>                 URL: https://issues.apache.org/jira/browse/KNOX-2393
>             Project: Apache Knox
>          Issue Type: Bug
>          Components: KnoxSSO
>            Reporter: Sandeep More
>            Assignee: Sandeep More
>            Priority: Major
>             Fix For: 1.4.0
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> There are some cases where browser sends automatic GET requests [1] (e.g. 
> favicon.ico) that can interfere with KnoxSSO flow depending on the timing of 
> the requests and cause SSO page to land on favicon icon.
> This could be achieved by adding a list of path for SSO to ignore using a 
> property  {{gateway.knox.sso.unauthenticated.path.list}}
> e.g.
> {code:xml}
>    <provider>
>            <role>federation</role>
>            <name>SSOCookieProvider</name>
>            <enabled>true</enabled>
>            <param>
>               <name>sso.authentication.provider.url</name>
>               <value>/gateway/knoxsso/api/v1/websso</value>
>            </param>
>            <param>
>               <name>gateway.knox.sso.unauthenticated.path.list</name>
>               <value>favicon.ico;test;unsafepath</value>
>            </param>
>     </provider>
>  {code}
> [1] [https://bugs.chromium.org/p/chromium/issues/detail?id=39402]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to