pzampino commented on a change in pull request #358:
URL: https://github.com/apache/knox/pull/358#discussion_r452261472
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/services/factory/RemoteRegistryClientServiceFactory.java
##########
@@ -26,20 +26,26 @@
import org.apache.knox.gateway.services.ServiceLifecycleException;
import org.apache.knox.gateway.services.ServiceType;
import
org.apache.knox.gateway.services.config.client.RemoteConfigurationRegistryClientService;
+import org.apache.knox.gateway.services.security.AliasService;
// There are two implementations of 'RemoteConfigurationRegistryClientService':
// - LocalFileSystemRemoteConfigurationRegistryClientService
// - CuratorClientService
// However, the first one - local - is for test-only purposes
public class RemoteRegistryClientServiceFactory extends AbstractServiceFactory
{
+ private final AliasServiceFactory aliasServiceFactory = new
AliasServiceFactory();
+
@Override
public Service create(GatewayServices gatewayServices, ServiceType
serviceType, GatewayConfig gatewayConfig, Map<String, String> options, String
implementation)
Review comment:
This is related to my most recent comment, I guess. Since there isn't
another known implementation, it currently cannot be overridden. So, the heart
of the matter is the ability to plug-in an arbitrary gateway service
implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
