smolnar82 commented on a change in pull request #361:
URL: https://github.com/apache/knox/pull/361#discussion_r454390468
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/services/factory/AliasServiceFactory.java
##########
@@ -54,7 +57,8 @@ protected Service createService(GatewayServices
gatewayServices, ServiceType ser
} else if (matchesImplementation(implementation,
RemoteAliasService.class)) {
service = new RemoteAliasService(defaultAliasService,
getMasterService(gatewayServices));
} else if (matchesImplementation(implementation,
ZookeeperRemoteAliasService.class)) {
- service = new
ZookeeperRemoteAliasServiceProvider().newInstance(defaultAliasService,
getMasterService(gatewayServices));
+ final boolean useLocalAliasService = options == null ? true :
Boolean.valueOf(options.getOrDefault(USE_LOCAL_ALIAS_IN_ZK_IMPL_PARAM_NAME,
"true"));
+ service = new
ZookeeperRemoteAliasServiceProvider().newInstance(useLocalAliasService ?
defaultAliasService : null, getMasterService(gatewayServices));
Review comment:
Nope. It means if you set the implementation to ZK in gateway-site.xml,
then tokens will be stored in ZK. The default is `DefaultAliasService`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
