smolnar82 commented on a change in pull request #365:
URL: https://github.com/apache/knox/pull/365#discussion_r480005728
##########
File path:
gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Ls.java
##########
@@ -41,6 +42,11 @@ public Request dir( String dir ) {
return this;
}
+ public Request knoxToken(String knoxToken) {
Review comment:
IMO, the token handling should happen on request level. But you are
right, this should not be limited to the `ls` command -> moving it to the
abstract parent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
