smolnar82 commented on a change in pull request #371:
URL: https://github.com/apache/knox/pull/371#discussion_r485142436
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/services/security/impl/DefaultAliasService.java
##########
@@ -194,6 +195,24 @@ public void removeAliasesForCluster(String clusterName,
Set<String> aliases) thr
return getPasswordFromAliasForCluster(NO_CLUSTER_NAME, alias);
}
+ //Overriding the default behavior as we want to avoid loading the keystore
N-times from the file system
+ @Override
Review comment:
So, in this case, the cluster we use is `__gateway` and the only reason
this method was added is to avoid exhausting I/O operations in the new
`AliasBasedTokenStateService.loadGatewayCredentialsOnStartup()` method.
Therefore I don't see if other methods should be changes within the scope of
this task.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
