moresandeep commented on a change in pull request #391:
URL: https://github.com/apache/knox/pull/391#discussion_r538431430
##########
File path:
gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/DefaultDispatch.java
##########
@@ -382,7 +382,14 @@ private String calculateResponseHeaderValue(Header
headerToCheck, Map<String, Se
return ""; // we should exclude all -> there should not be any value
added with this header
} else {
final String separator =
SET_COOKIE.equalsIgnoreCase(headerNameToCheck) ? "; " : " ";
- Set<String> headerValuesToCheck = new
HashSet<>(Arrays.asList(headerToCheck.getValue().trim().split("\\s+")));
+ Set<String> headerValuesToCheck;
+ if(headerToCheck.getName().equalsIgnoreCase(SET_COOKIE)) {
+ headerValuesToCheck = new
HashSet<>(Arrays.asList(headerToCheck.getValue().trim().split(";")));
+ /* trim */
+ headerValuesToCheck =
headerValuesToCheck.stream().map(String::trim).collect(Collectors.toSet());
+ } else {
+ headerValuesToCheck = new
HashSet<>(Arrays.asList(headerToCheck.getValue().trim().split("\\s+")));
+ }
headerValuesToCheck = headerValuesToCheck.stream().map(h ->
h.replaceAll(separator.trim(), "")).collect(Collectors.toSet());
Review comment:
Sorry i did not follow, in case of line 389 we need trimming for the
case where cookies use spaces and ; together.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
