[ 
https://issues.apache.org/jira/browse/KNOX-2509?focusedWorklogId=524486&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-524486
 ]

ASF GitHub Bot logged work on KNOX-2509:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Dec/20 14:48
            Start Date: 15/Dec/20 14:48
    Worklog Time Spent: 10m 
      Work Description: smolnar82 commented on a change in pull request #393:
URL: https://github.com/apache/knox/pull/393#discussion_r543410036



##########
File path: gateway-openapi-ui/pom.xml
##########
@@ -0,0 +1,90 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0";
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+    <modelVersion>4.0.0</modelVersion>
+    <parent>
+        <groupId>org.apache.knox</groupId>
+        <artifactId>gateway</artifactId>
+        <version>1.5.0-SNAPSHOT</version>
+    </parent>
+
+    <artifactId>gateway-openapi-ui</artifactId>
+    <name>gateway-openapi-ui</name>
+    <packaging>jar</packaging>
+    <description>Generating Open API (aka. Swagger) UI</description>
+
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>com.github.kongchen</groupId>
+                <artifactId>swagger-maven-plugin</artifactId>
+                <version>3.1.7</version>

Review comment:
       Yes, this was an oversight.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 524486)
    Time Spent: 0.5h  (was: 20m)

> Use Open API UI to browse the Knox Admin/Metadata API REST endpoints
> --------------------------------------------------------------------
>
>                 Key: KNOX-2509
>                 URL: https://issues.apache.org/jira/browse/KNOX-2509
>             Project: Apache Knox
>          Issue Type: New Feature
>          Components: Homepage, Server
>    Affects Versions: 1.5.0
>            Reporter: Sandor Molnar
>            Assignee: Sandor Molnar
>            Priority: Major
>             Fix For: 1.6.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> I had some contribution that allows end-users managing service definitions 
> without restarting the Knox Gateway. See KNOX-2053 and KNOX-2056 for further 
> details.
>  
> I've been just about creating a new JIRA to document those new API endpoints 
> in the Knox user guide but it has come to my mind that we can do it much 
> better by using Swagger.
>  
> Given the fact, the Admin/Metadata API does not consist of hundreds of 
> existing endpoints it should not be 'that' huge work. I personally believe 
> the project would gain a lot by using this very useful tool. This way the 
> Admin/Metadata API documentation would be generated out-of-the-box, no more 
> documentation JIRAs required. Moreover, the generated documentation would be 
> in sync with the actual implementation.
> You can check this out here: [https://swagger.io/tools/swagger-ui/] (there is 
> a live demo too; it's worth looking at).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to