smolnar82 commented on a change in pull request #393:
URL: https://github.com/apache/knox/pull/393#discussion_r543416351
##########
File path: pom.xml
##########
@@ -438,6 +440,12 @@
<exclude>atlassian-ide-plugin.xml</exclude>
<exclude>**/PULL_REQUEST_TEMPLATE*</exclude>
<exclude>**/new-service-definition-template.xml</exclude>
+ <exclude>**/swagger/*.js</exclude>
+ <exclude>**/swagger/*.js.map</exclude>
+ <exclude>**/swagger/*.html</exclude>
+ <exclude>**/swagger/*.css</exclude>
+ <exclude>**/swagger/*.css.map</exclude>
+ <exclude>**/swagger/*.md</exclude>
Review comment:
So basically, as I explained in the PR description above, these files
were downloaded from OpenAPI homepage and were unpacked. I did not want to use
[npm](https://www.npmjs.com/package/swagger-ui), because I had to Knoxify the
`index.html` page.
Do you think we should add our Apache license into these downloaded static
files too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
