pzampino commented on a change in pull request #398:
URL: https://github.com/apache/knox/pull/398#discussion_r561942047
##########
File path:
gateway-discovery-cm/src/main/java/org/apache/knox/gateway/topology/discovery/cm/ServiceModel.java
##########
@@ -37,6 +37,9 @@
private final String roleType;
private final String serviceUrl;
+ // Metadata for the model object, which is not directly from the service or
role configuration
+ private final Map<String, String> modelProperties = new
ConcurrentHashMap<>();
Review comment:
You're probably correct. I went back and forth on that naming choice.
##########
File path:
gateway-discovery-cm/src/main/java/org/apache/knox/gateway/topology/discovery/cm/ServiceModel.java
##########
@@ -37,6 +37,9 @@
private final String roleType;
private final String serviceUrl;
+ // Metadata for the model object, which is not directly from the service or
role configuration
+ private final Map<String, String> modelProperties = new
ConcurrentHashMap<>();
Review comment:
New PS in progress...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
