iain-buclaw-sociomantic commented on a change in pull request #399:
URL: https://github.com/apache/knox/pull/399#discussion_r562469416



##########
File path: 
gateway-service-definitions/src/main/resources/services/yarnui/2.7.0/rewrite.xml
##########
@@ -219,6 +218,11 @@
         <apply path="https?://[^/':,]+:[\d][^']*" 
rule="YARNUI/yarn/outbound/node2"/>
     </content>
 </filter>
+<filter name="YARNUI/yarn/outbound/filter/cluster1">

Review comment:
       > @moresandeep going to try altering the path for the 
`YARNUI/yarn/outbound/apps/cluster1` then. Currently rebuilding and deploying 
locally.
   
   So I see no problems yet running with this patch.  The Kill button works, 
and everything else seems functional (except for the history url noted in 
KNOX-2528/KNOX-1032).
   
   If I understand the rules and patterns correctly, I can't imagine anything 
should really break as a result of this, because `/ws/v1/.*` catches and 
handles `/ws/v1/cluster/apps/application` correctly.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to