pzampino commented on a change in pull request #424:
URL: https://github.com/apache/knox/pull/424#discussion_r601765801
##########
File path:
gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/AbstractJWTFilter.java
##########
@@ -174,11 +175,9 @@ protected void configureExpectedParameters(FilterConfig
filterConfig) {
return audList;
}
- protected boolean tokenIsStillValid(JWT jwtToken) throws
UnknownTokenException {
- Date expires;
- if (tokenStateService != null) {
- expires = new Date(tokenStateService.getTokenExpiration(jwtToken));
- } else {
+ protected boolean tokenIsStillValid(final JWT jwtToken) throws
UnknownTokenException {
+ Date expires =
getServerManagedStateExpiration(TokenUtils.getTokenId(jwtToken));
+ if (expires == null) {
Review comment:
I don't believe so; The UnknownTokenException should work its way back
to the validateToken method where it is handled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
