[
https://issues.apache.org/jira/browse/KNOX-2562?focusedWorklogId=574296&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-574296
]
ASF GitHub Bot logged work on KNOX-2562:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Mar/21 18:01
Start Date: 30/Mar/21 18:01
Worklog Time Spent: 10m
Work Description: smolnar82 commented on a change in pull request #426:
URL: https://github.com/apache/knox/pull/426#discussion_r604318035
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/services/token/impl/AliasBasedTokenStateService.java
##########
@@ -446,13 +446,15 @@ protected void addMetadataInMemory(String tokenId,
TokenMetadata metadata) {
}
@Override
- public TokenMetadata getTokenMetadata(String tokenId) {
+ public TokenMetadata getTokenMetadata(String tokenId) throws
UnknownTokenException {
TokenMetadata tokenMetadata = super.getTokenMetadata(tokenId);
Review comment:
UnknownTokenException should be handled. In HA case it may happen that
the in-memory collection will not have the given token metadata -> super will
throw UTE. We should catch it and continue with the alias service action.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 574296)
Time Spent: 20m (was: 10m)
> TokenStateService getTokenMetadata method should throw UnknownTokenException
> ----------------------------------------------------------------------------
>
> Key: KNOX-2562
> URL: https://issues.apache.org/jira/browse/KNOX-2562
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Affects Versions: 1.6.0
> Reporter: Philip Zampino
> Assignee: Philip Zampino
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The TokenStateService getTokenMetadata method should throw
> UnknownTokenException if an invalid token identifier is specified.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
