mudit-97 commented on a change in pull request #423:
URL: https://github.com/apache/knox/pull/423#discussion_r605892461
##########
File path:
gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/ConfigurableDispatch.java
##########
@@ -41,13 +47,26 @@
public class ConfigurableDispatch extends DefaultDispatch {
private Set<String> requestExcludeHeaders =
super.getOutboundRequestExcludeHeaders();
private Set<String> responseExcludeHeaders =
super.getOutboundResponseExcludeHeaders();
+ private Map<String, String> requestAppendHeaders = new HashMap<>();
private Set<String> responseExcludeSetCookieHeaderDirectives =
super.getOutboundResponseExcludedSetCookieHeaderDirectives();
private Boolean removeUrlEncoding = false;
private Set<String> convertCommaDelimitedHeadersToSet(String headers) {
return headers == null ? Collections.emptySet(): new
HashSet<>(Arrays.asList(headers.split("\\s*,\\s*")));
}
+ private Map<String, String> convertJSONHeadersToMap(String headers) {
Review comment:
I had some doubts around this. I checked that in CustomDispatch, there
is one xml param support:
@XmlAttribute(name = "use-two-way-ssl")
public boolean getUseTwoWaySsl() {
return useTwoWaySsl;
}
and xml will look like this:
<requestAppendHeaders>
<header>
<name>a</name>
<value>b</value>
</header>
<header>
<name>c</name>
<value>d</value>
</header>
</requestAppendHeaders>
Are you suggesting that we should have a new parameter requestAppendHeaders
or are you suggesting a layout like this:
<param>
<requestAppendHeaders>
<header>
<name>a</name>
<value>b</value>
</header>
<header>
<name>c</name>
<value>d</value>
</header>
</requestAppendHeaders>
</param>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
