moresandeep commented on a change in pull request #445:
URL: https://github.com/apache/knox/pull/445#discussion_r626000702



##########
File path: 
gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/JWTFederationFilter.java
##########
@@ -31,15 +35,22 @@
 import javax.servlet.ServletResponse;
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
-
 import java.io.IOException;
 import java.nio.charset.StandardCharsets;
 import java.text.ParseException;
 import java.util.Base64;
+import java.util.HashSet;
 import java.util.Locale;
+import java.util.Set;
+import java.util.StringTokenizer;
 
 public class JWTFederationFilter extends AbstractJWTFilter {
 
+  private static final JWTMessages LOGGER = MessagesFactory.get( 
JWTMessages.class );
+  /* A semicolon separated list of paths that need to bypass authentication */
+  public static final String JWT_UNAUTHENTICATED_PATHS_PARAM = 
"jwt.unauthenticated.path.list";
+  public static final String DEFAULT_JWT_UNAUTHENTICATED_PATHS_PARAM = 
"/knoxtoken/api/v1/jwks.json";

Review comment:
       I moved it to a common util class along with other methods you pointed 
out. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to