lmccay commented on a change in pull request #456:
URL: https://github.com/apache/knox/pull/456#discussion_r648502609
##########
File path:
gateway-provider-ha/src/main/java/org/apache/knox/gateway/ha/dispatch/ConfigurableHADispatch.java
##########
@@ -224,7 +224,7 @@ private void setKnoxHaCookie(HttpServletRequest
inboundRequest,
protected void failoverRequest(HttpUriRequest outboundRequest,
HttpServletRequest inboundRequest, HttpServletResponse outboundResponse,
HttpResponse inboundResponse, Exception exception) throws IOException {
/* check for a case where no fallback is configured */
- if(stickySessionsEnabled && noFallbackEnabled) {
+ if(stickySessionsEnabled && noFallbackEnabled &&
inboundRequest.getCookies() != null) {
Review comment:
Is it sufficient to check that there are no cookies at all or do we need
to check for our own cookie for the sticky sessions? I suppose that the
currently the driver isn't proactively adding a cookie to the first request but
can we count on that assumption not going bad?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
