[
https://issues.apache.org/jira/browse/KNOX-2619?focusedWorklogId=609254&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-609254
]
ASF GitHub Bot logged work on KNOX-2619:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jun/21 17:00
Start Date: 09/Jun/21 17:00
Worklog Time Spent: 10m
Work Description: lmccay commented on a change in pull request #456:
URL: https://github.com/apache/knox/pull/456#discussion_r648502609
##########
File path:
gateway-provider-ha/src/main/java/org/apache/knox/gateway/ha/dispatch/ConfigurableHADispatch.java
##########
@@ -224,7 +224,7 @@ private void setKnoxHaCookie(HttpServletRequest
inboundRequest,
protected void failoverRequest(HttpUriRequest outboundRequest,
HttpServletRequest inboundRequest, HttpServletResponse outboundResponse,
HttpResponse inboundResponse, Exception exception) throws IOException {
/* check for a case where no fallback is configured */
- if(stickySessionsEnabled && noFallbackEnabled) {
+ if(stickySessionsEnabled && noFallbackEnabled &&
inboundRequest.getCookies() != null) {
Review comment:
Is it sufficient to check that there are no cookies at all or do we need
to check for our own cookie for the sticky sessions? I suppose that the
currently the driver isn't proactively adding a cookie to the first request but
can we count on that assumption not going bad?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 609254)
Time Spent: 20m (was: 10m)
> HA dispatch should failover regardless of noFallback config until session is
> established
> ----------------------------------------------------------------------------------------
>
> Key: KNOX-2619
> URL: https://issues.apache.org/jira/browse/KNOX-2619
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Affects Versions: 1.6.0
> Reporter: Philip Zampino
> Assignee: Philip Zampino
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When enableStickySession=true and noFallback=true, and the attempt to
> establish the session fails, the ConfigurableHaDispatch does not failover
> because of the noFallback configuration.
> Instead, it should failover until a session can be established, and then
> honor the noFallback configuration from that point forward.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
