smolnar82 edited a comment on pull request #462:
URL: https://github.com/apache/knox/pull/462#issuecomment-877857475


   > What about a test?
   
   Thanks for your review, @pzampino !
   I modified 
`AliasBasedTokenStateServiceTest.testAddAndRemoveTokenIncludesCache()` to match 
the exact alias name list at removal time (instead of `anyObject`), so that we 
can make sure the appropriate alias removals happen.
   In addition to this, I added code to make sure that information is moved 
from the in-memory cache too.
   
   Since you already approved, let me wait for a green build and merge this 
change.
   
   Thanks again!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to