[
https://issues.apache.org/jira/browse/KNOX-2637?focusedWorklogId=625598&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-625598
]
ASF GitHub Bot logged work on KNOX-2637:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jul/21 13:27
Start Date: 20/Jul/21 13:27
Worklog Time Spent: 10m
Work Description: moresandeep commented on a change in pull request #471:
URL: https://github.com/apache/knox/pull/471#discussion_r673119360
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/util/KnoxCLI.java
##########
@@ -63,34 +93,15 @@
import org.jboss.shrinkwrap.api.exporter.ExplodedExporter;
import org.jboss.shrinkwrap.api.spec.EnterpriseArchive;
-import javax.net.ssl.SSLException;
-import java.io.BufferedReader;
-import java.io.Console;
-import java.io.File;
-import java.io.IOException;
-import java.io.InputStream;
-import java.io.InputStreamReader;
-import java.io.PrintStream;
-import java.net.InetAddress;
-import java.net.UnknownHostException;
-import java.nio.charset.StandardCharsets;
-import java.nio.file.Path;
-import java.nio.file.Paths;
-import java.security.KeyStoreException;
-import java.security.cert.Certificate;
-import java.security.cert.X509Certificate;
-import java.util.Arrays;
-import java.util.HashMap;
-import java.util.HashSet;
-import java.util.List;
-import java.util.Locale;
-import java.util.Map;
-import java.util.Properties;
-import java.util.Set;
-import java.util.UUID;
+import com.nimbusds.jose.JOSEException;
+import com.nimbusds.jose.JWSAlgorithm;
+import com.nimbusds.jose.jwk.OctetSequenceKey;
+import com.nimbusds.jose.jwk.gen.OctetSequenceKeyGenerator;
public class KnoxCLI extends Configured implements Tool {
+ private static final Collection<String> SUPPORTED_JWK_ALGORITHMS = Stream
Review comment:
Wouldn't it be better to make it Set instead of Collection. It will be
easier to follow the references later on in the code and if needed Iterable can
be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 625598)
Time Spent: 1h 10m (was: 1h)
> New Knox CLI command to generate a valid JWK secret
> ---------------------------------------------------
>
> Key: KNOX-2637
> URL: https://issues.apache.org/jira/browse/KNOX-2637
> Project: Apache Knox
> Issue Type: Task
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> It'd be great to have a Knox CLI command that generates a valid JWK secret
> and displays that on the screen.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
