pzampino commented on a change in pull request #473:
URL: https://github.com/apache/knox/pull/473#discussion_r676646122
##########
File path:
gateway-provider-security-pac4j/src/main/java/org/apache/knox/gateway/pac4j/filter/Pac4jDispatcherFilter.java
##########
@@ -214,6 +214,18 @@ public void init( FilterConfig filterConfig ) throws
ServletException {
}
+ private String resolveAlias(String clusterName, String key, String value)
throws ServletException {
+ if (value.startsWith("${ALIAS=") && value.endsWith("}")) {
+ String alias = value.substring("${ALIAS=".length());
Review comment:
Why not remove the end delimiter here instead of performing another
substring subsequently?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
