[
https://issues.apache.org/jira/browse/KNOX-2534?focusedWorklogId=627778&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627778
]
ASF GitHub Bot logged work on KNOX-2534:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jul/21 14:18
Start Date: 26/Jul/21 14:18
Worklog Time Spent: 10m
Work Description: pzampino commented on a change in pull request #473:
URL: https://github.com/apache/knox/pull/473#discussion_r676646122
##########
File path:
gateway-provider-security-pac4j/src/main/java/org/apache/knox/gateway/pac4j/filter/Pac4jDispatcherFilter.java
##########
@@ -214,6 +214,18 @@ public void init( FilterConfig filterConfig ) throws
ServletException {
}
+ private String resolveAlias(String clusterName, String key, String value)
throws ServletException {
+ if (value.startsWith("${ALIAS=") && value.endsWith("}")) {
+ String alias = value.substring("${ALIAS=".length());
Review comment:
Why not remove the end delimiter here with an end index instead of
performing another substring subsequently?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 627778)
Time Spent: 40m (was: 0.5h)
> Allow alias to be used in pac4j topology block
> ----------------------------------------------
>
> Key: KNOX-2534
> URL: https://issues.apache.org/jira/browse/KNOX-2534
> Project: Apache Knox
> Issue Type: Improvement
> Components: KnoxSSO
> Reporter: Michael Boulter
> Assignee: Attila Magyar
> Priority: Minor
> Attachments: knoxsso-oidc.xml
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> We currently use Knox to authenticate users with Microsoft via pac4j
> federation config.
> We have an OIDC client secret (oidc.secret) stored in plaintext in the
> topology file but we'd like to obfuscate and not have the plaintext value in
> the topology XML.
>
> This is because OAuth strongly recommends to have the "client secret"
> protected.
>
> The alias service currently only seems to work for LDAP, it would be good if
> we could use it inside our pac4j block too.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
