YunLemon commented on pull request #482:
URL: https://github.com/apache/knox/pull/482#issuecomment-899918423


   `depth` doesn't squash commits, instead of cloning the complete repository 
(as usually done with git), using clone depth just clones the last 
clone-depth-number revisions of your repository.
   According to [Disadvantages of shallow cloning on Travis and other CI 
services?](https://stackoverflow.com/questions/31278233/disadvantages-of-shallow-cloning-on-travis-and-other-ci-services),
 there are two main problems with using shallow clones:
   1. Push too fast. Can you really push so fast?
   2. Restart an old build. Do you have this need?
   For a PR can have more than 3 commits, I don't think `depth` will be an 
issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to