zeroflag commented on a change in pull request #484:
URL: https://github.com/apache/knox/pull/484#discussion_r694995989
##########
File path:
gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java
##########
@@ -741,4 +741,7 @@ private String safeGetMessage(Throwable t) {
return message != null ? message : "null";
}
+ void setTokenLimitPerUser(int tokenLimitPerUser) { // visible for testing
Review comment:
I'm not a fan of any of those (adding the accessor / using reflection)
but thought this way is a little bit better. With reflection I need to
reference the field name as a String which is not refactoring friendly.
I'll see if I can reconfigure the mocks and call the init() on the
TokenResource again to change the limit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
