[
https://issues.apache.org/jira/browse/KNOX-2625?focusedWorklogId=643024&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-643024
]
ASF GitHub Bot logged work on KNOX-2625:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Aug/21 22:01
Start Date: 27/Aug/21 22:01
Worklog Time Spent: 10m
Work Description: lmccay commented on a change in pull request #476:
URL: https://github.com/apache/knox/pull/476#discussion_r697740738
##########
File path:
gateway-applications/src/main/resources/applications/knoxauth/app/logout.jsp
##########
@@ -62,15 +75,41 @@
whitelist = "";
}
}
+
+ boolean validRedirect = false;
String origUrl = request.getParameter("originalUrl");
String del = "?";
- if (origUrl.contains("?")) {
+ if (origUrl != null && origUrl.contains("?")) {
del = "&";
}
- boolean validRedirect = RegExUtils.checkWhitelist(whitelist, origUrl);
- if (("1".equals(request.getParameter("returnToApp"))) &&
validRedirect) {
- response.setStatus(response.SC_MOVED_PERMANENTLY);
- response.setHeader("Location",originalUrl + del + "refresh=1");
+ if (origUrl != null) {
Review comment:
It used later in the JSP to determine whether to display the link back
to the app.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 643024)
Time Spent: 0.5h (was: 20m)
> Enhance KnoxSSO to Support Session Timeout and Logout
> -----------------------------------------------------
>
> Key: KNOX-2625
> URL: https://issues.apache.org/jira/browse/KNOX-2625
> Project: Apache Knox
> Issue Type: Improvement
> Components: KnoxSSO
> Reporter: Larry McCay
> Assignee: Larry McCay
> Priority: Major
> Fix For: 1.6.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> By extending the WebSSOResource in KnoxSSO to accept redirects with a
> session-state query param, we can provide hooks for handling session
> expiry/timeout and logout.
> This will assume that a participating application redirects to a given
> session timeout or logout page which can be rewritten to or be configured to
> be the knoxsso endpoint with a session-state change query param.
> We will then be able to determine how to handle each and to give the user a
> choice when appropriate.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
