[
https://issues.apache.org/jira/browse/KNOX-1462?focusedWorklogId=649924&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649924
]
ASF GitHub Bot logged work on KNOX-1462:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Sep/21 10:56
Start Date: 13/Sep/21 10:56
Worklog Time Spent: 10m
Work Description: zeroflag commented on a change in pull request #488:
URL: https://github.com/apache/knox/pull/488#discussion_r707223972
##########
File path:
gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/identityasserter/common/filter/AbstractIdentityAssertionFilter.java
##########
@@ -110,7 +111,9 @@ protected void
continueChainAsPrincipal(HttpServletRequestWrapper request, Servl
if (primaryPrincipal != null) {
if (!primaryPrincipal.getName().equals(mappedPrincipalName)) {
impersonationNeeded = true;
- auditService.getContext().setProxyUsername( mappedPrincipalName );
+ AuditContext context = auditService.getContext();
+ context.setProxyUsername( mappedPrincipalName );
+ auditService.attachContext(context);
Review comment:
In log4j1 the `MDC` held a reference to an object, so changing the
`proxyUserName` on this object changed the `MDC` as well. But in log4j2 there
is a `ThreadContext` instead of `MDC` which can hold only key value pairs. So
changing the `proxyUserName` on the `AuditContext` won't change the the
threadContext without reattaching (thus populating the key values) again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 649924)
Time Spent: 3h 20m (was: 3h 10m)
> Migrate from Log4j 1.x to 2.x
> -----------------------------
>
> Key: KNOX-1462
> URL: https://issues.apache.org/jira/browse/KNOX-1462
> Project: Apache Knox
> Issue Type: Improvement
> Reporter: Kevin Risden
> Assignee: Attila Magyar
> Priority: Blocker
> Fix For: 2.0.0
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Assigning to version 1.2.0 to have a discussion about it.
> Log4j 1.x went EOL in August 2015. JDK 9+ support (KNOX-1458) will require
> Log4j 2 since Knox uses MDC for all the audit logging. More details about the
> issue and migration are found here:
> * [https://blogs.apache.org/logging/entry/moving_on_to_log4j_2]
> * [https://logging.apache.org/log4j/2.x/manual/migration.html]
> Items of "concern"
> * MDC migrate to ThreadContext
> * log4j.properties need to migrate to log4j2.xml (or yaml or json)
> Benefits
> * Async logging
> * Dynamic reloading of configuration changes
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
