[
https://issues.apache.org/jira/browse/KNOX-1462?focusedWorklogId=650981&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-650981
]
ASF GitHub Bot logged work on KNOX-1462:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Sep/21 08:58
Start Date: 15/Sep/21 08:58
Worklog Time Spent: 10m
Work Description: zeroflag commented on pull request #488:
URL: https://github.com/apache/knox/pull/488#issuecomment-919832184
> * This looks like it completely removes slf4j - is that correct? would it
make sense to have the slf4j->log4j2 bridge added for any dependency that might
use slf4j for logging?
@risdenk Thanks for going through this big patch.
At a few places in the Knox code we used `org.slf4j.LoggerFactory` and
`org.slf4j.Logger` directly. I replaced these with Log4j2 and removed the slf4j
dependency to make sure we won't use these again.
If there is a third party dependency that uses slf4j for logging, that still
should work since we have `log4j-slf4j-impl-2.14.0.jar` on the class path.
```
$ ls -al dep/ | grep log4j
-rw-r--r-- 1 amagyar staff 301418 Jan 22 2020 log4j-api-2.14.0.jar
-rw-r--r-- 1 amagyar staff 1762731 Jan 22 2020 log4j-core-2.14.0.jar
-rw-r--r-- 1 amagyar staff 23871 Jan 22 2020
log4j-slf4j-impl-2.14.0.jar
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 650981)
Time Spent: 6h (was: 5h 50m)
> Migrate from Log4j 1.x to 2.x
> -----------------------------
>
> Key: KNOX-1462
> URL: https://issues.apache.org/jira/browse/KNOX-1462
> Project: Apache Knox
> Issue Type: Improvement
> Reporter: Kevin Risden
> Assignee: Attila Magyar
> Priority: Blocker
> Fix For: 2.0.0
>
> Time Spent: 6h
> Remaining Estimate: 0h
>
> Assigning to version 1.2.0 to have a discussion about it.
> Log4j 1.x went EOL in August 2015. JDK 9+ support (KNOX-1458) will require
> Log4j 2 since Knox uses MDC for all the audit logging. More details about the
> issue and migration are found here:
> * [https://blogs.apache.org/logging/entry/moving_on_to_log4j_2]
> * [https://logging.apache.org/log4j/2.x/manual/migration.html]
> Items of "concern"
> * MDC migrate to ThreadContext
> * log4j.properties need to migrate to log4j2.xml (or yaml or json)
> Benefits
> * Async logging
> * Dynamic reloading of configuration changes
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
