ashutoshm commented on a change in pull request #489:
URL: https://github.com/apache/knox/pull/489#discussion_r709316096



##########
File path: 
gateway-service-definitions/src/main/resources/services/atlas/2.1.0/rewrite.xml
##########
@@ -32,14 +32,20 @@
         <rewrite template="{$frontend[path]}/atlas/"/>
     </rule>
 
-    <rule dir="OUT" name="ATLAS/atlas/outbound/login/headers/location">
-        <match pattern="*://*:*/login.jsp"/>
-        <rewrite template="{$frontend[url]}/atlas/login.jsp"/>
+    <rule dir="OUT" name="ATLAS/atlas/outbound/login/headers/location" 
flow="OR">
+        <match pattern="*://*:*/login.jsp">
+            <rewrite 
template="https://{$frontend[addr]}/gateway/knoxsso/knoxauth/logout.jsp?originalUrl={$postfix[url,/atlas/]}";
 />
+        </match>
+
+        <match pattern="*://*:*/logout.html?{**}">
+            <rewrite 
template="https://{$frontend[addr]}/gateway/knoxsso/knoxauth/logout.jsp?{**}"/>

Review comment:
       @moresandeep Fix would be to replace gateway with {gateway} and knoxsso 
with {knoxsso}. Correct?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to