smolnar82 commented on a change in pull request #509:
URL: https://github.com/apache/knox/pull/509#discussion_r727068387
##########
File path:
gateway-provider-security-pac4j/src/main/java/org/apache/knox/gateway/pac4j/filter/Pac4jDispatcherFilter.java
##########
@@ -187,6 +200,27 @@ public void init( FilterConfig filterConfig ) throws
ServletException {
clientName = CommonHelper.isBlank(clientNameParameter) ?
clients.get(0).getName() : clientNameParameter;
+ /* do we need to exclude groups? */
+ if (filterConfig.getInitParameter(PAC4J_SESSION_STORE_EXCLUDE_GROUPS) ==
null) {
Review comment:
This pattern could be replaced w/ a private method:
```
private void setSessionStoreConfig(FilterConfig filterConfig, String
configName, String configDefault) {
final String configValue = filterConfig.getInitParameter(configName);
sessionStoreConfigs.put(configValue == null ? configDefault :
configValue);
}
```
Then you could have the following here:
```
setSessionStoreConfig(PAC4J_SESSION_STORE_EXCLUDE_GROUPS,
PAC4J_SESSION_STORE_EXCLUDE_GROUPS_DEFAULT);
setSessionStoreConfig(PAC4J_SESSION_STORE_EXCLUDE_ROLES,
PAC4J_SESSION_STORE_EXCLUDE_ROLES_DEFAULT);
setSessionStoreConfig(PAC4J_SESSION_STORE_EXCLUDE_PERMISSIONS,
PAC4J_SESSION_STORE_EXCLUDE_PERMISSIONS_DEFAULT);
```
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
