[
https://issues.apache.org/jira/browse/KNOX-2692?focusedWorklogId=687394&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-687394
]
ASF GitHub Bot logged work on KNOX-2692:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Nov/21 16:03
Start Date: 29/Nov/21 16:03
Worklog Time Spent: 10m
Work Description: smolnar82 opened a new pull request #520:
URL: https://github.com/apache/knox/pull/520
## What changes were proposed in this pull request?
To support backward compatibility, a new Gateway-level configuration is
introduced to allow end-users to configure if they require changes in
topologies for redeployment or a simple `touch` is enough (relying on the
topology file's timestamp).
## How was this patch tested?
Updated and executed JUnit tests. In addition to unit testing, I ran the
following manual test steps:
- redeployed Knox w/ my changes
- confirmed that `touch conf/topologies/sandbox.xml` re-deployed the
`sandbox` topology
- edit `gateway-site.xml` (set
`gateway.topology.redeploy.requires.changes=true`) and re-started Knox
- confirmed that
- `touch conf/topologies/sandbox.xml` did not re-deploy the `sandbox`
topology
- `bin/knoxcli.sh redeploy --cluster sandbox` re-deployed the `sandbox`
topology
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 687394)
Remaining Estimate: 0h
Time Spent: 10m
> Topology redeployment should be configurable
> --------------------------------------------
>
> Key: KNOX-2692
> URL: https://issues.apache.org/jira/browse/KNOX-2692
> Project: Apache Knox
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Major
> Fix For: 2.0.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> With a recent change for KNOX-2689, XML-based topologies are re-deployed
> only, if there is an actual change in the topology. This commit invalidates a
> well-known redeploy "technic" of touching the topology file.
> [~lmccay] indicated this in Knox's DEV/USER mailing lists so I discussed this
> matter offline with some Knox team members and we agreed the following should
> be implemented to make this behavior configurable and be backward compatible
> OOTB with previous Knox versions:
> * a new gateway-site.xml param to be added, called
> {{{}gateway.topology.redeploy.requires.changes{}}}, to indicate if we
> equality check should be skipped. Defaults to {{false}} to be backward
> compatible.
> * in {{DefaultTopologyService}} the redeploy logic I added recently should
> be modified to check if an equality check is needed or not
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
