zeroflag commented on a change in pull request #534:
URL: https://github.com/apache/knox/pull/534#discussion_r792495286
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/GatewayFilter.java
##########
@@ -150,7 +153,13 @@ public void doFilter( ServletRequest servletRequest,
ServletResponse servletResp
}
}
- assignCorrelationRequestId();
+ /* If request contains X-Request-Id header use it else use random uuid as
correlation id */
+ final String req_id = ((HttpServletRequest)
servletRequest).getHeader(REQUEST_ID_HEADER_NAME);
Review comment:
LGTM, just a nitpick here, why don't we use camel case names here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
