[
https://issues.apache.org/jira/browse/KNOX-2704?focusedWorklogId=715659&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-715659
]
ASF GitHub Bot logged work on KNOX-2704:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jan/22 13:00
Start Date: 26/Jan/22 13:00
Worklog Time Spent: 10m
Work Description: smolnar82 commented on a change in pull request #534:
URL: https://github.com/apache/knox/pull/534#discussion_r792610683
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/GatewayFilter.java
##########
@@ -150,7 +153,13 @@ public void doFilter( ServletRequest servletRequest,
ServletResponse servletResp
}
}
- assignCorrelationRequestId();
+ /* If request contains X-Request-Id header use it else use random uuid as
correlation id */
+ final String req_id = ((HttpServletRequest)
servletRequest).getHeader(REQUEST_ID_HEADER_NAME);
Review comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 715659)
Time Spent: 0.5h (was: 20m)
> Honor request id (correlation id) set by upstream loadbalancer
> --------------------------------------------------------------
>
> Key: KNOX-2704
> URL: https://issues.apache.org/jira/browse/KNOX-2704
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Reporter: Sandeep More
> Assignee: Sandeep More
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In case request Id/correlation id is set by upstream LB (e.g. nginix) (or
> other components) do not generate one and use the one passed.
> Request Id also known as trace id is passed as a "X-Request-Id" header
> value. This is a good blog post on how it can be used
> https://blog.heroku.com/http_request_id_s_improve_visibility_across_the_application_stack
> This would help Knox be in line with other components supporting trace id for
> better telemetry and tracing.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
