zeroflag commented on a change in pull request #537: URL: https://github.com/apache/knox/pull/537#discussion_r811839946
########## File path: gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/IdentityAsserterMessages.java ########## @@ -17,12 +17,37 @@ */ package org.apache.knox.gateway; +import java.util.Set; + import org.apache.knox.gateway.i18n.messages.Message; import org.apache.knox.gateway.i18n.messages.MessageLevel; import org.apache.knox.gateway.i18n.messages.Messages; +import org.apache.knox.gateway.plang.Ast; +import org.apache.knox.gateway.plang.SyntaxException; @Messages(logger="org.apache.knox.gateway") public interface IdentityAsserterMessages { @Message( level = MessageLevel.ERROR, text = "Required subject/identity not available. Check authentication/federation provider for proper configuration." ) void subjectNotAvailable(); + + @Message( level = MessageLevel.WARN, text = "Virtual group name is missing after dot character.") + void missingVirtualGroupName(); + + @Message( level = MessageLevel.WARN, text = "Parse error: {2}. At {0}={1}") + void parseError(String key, String script, SyntaxException e); + + @Message( level = MessageLevel.WARN, text = "Invalid result: {2}. Expected boolean when evaluating: {1}. For virtualGroup: {0}") + void invalidResult(String virtualGroupName, Ast ast, Object result); + + @Message( level = MessageLevel.DEBUG, text = "Adding user: {0} to virtual group: {1} using predicate: {2}") + void addingUserToVirtualGroup(String username, String virtualGroupName, Ast ast); + + @Message( level = MessageLevel.DEBUG, text = "Not adding user: {0} to virtual group: {1} using predicate: {2}") + void notAddingUserToVirtualGroup(String username, String virtualGroupName, Ast ast); + + @Message( level = MessageLevel.DEBUG, text = "Checking user: {0} (with groups: {1}) whether to add virtualGroup: {2} using predicate: {3}") + void checkingVirtualGroup(String userName, Set<String> userGroups, String virtualGroupName, Ast ast); + + @Message( level = MessageLevel.INFO, text = "User: {0} (with groups: {1}) added to virtual groups: {2}") Review comment: Yes, audit logs shows the end result. This is only useful for showing the original groups as well. How about changing it to DEBUG? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org