zeroflag edited a comment on pull request #537: URL: https://github.com/apache/knox/pull/537#issuecomment-1049771263
> It's difficult for me to tell, but is there any testing of the combined (old/new) mapping configuration syntax? Yes, in the `CommonIdentityAssertionFilterTest` there is one for testing the combination of both (where we map the principal to another one and use that one from the predicate). Testing this feature at the Filter level is cumbersome because of the infrastructure related code and dependencies (servlet api and such), so the more extensive tests are in `VirtualGroupMapperTests`, `ParserTest` and `InterpreterTest`. Those are more focused and easier to write tests for. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
